D28767: SEP Focus improvements

Eric Dejouhanet noreply at phabricator.kde.org
Thu Apr 16 21:41:58 BST 2020

TallFurryMan accepted this revision.
TallFurryMan added a comment.

  I will certainly not block a differential on an issue with source centers which we do not use afterwards :) Sorry for forgetting the "Accept Revision" flag.
  My point was really simply that the code was previously drawing canvas ellipses with drawEllipses() using the top-left and width/height values, while the new one is using the center point and radius values.
  When you use the center with the second prototype, you risk offsetting your ellipse/circle by one (eventually scaled) pixel, while using an enclosing rect is a better approach in my opinion when the picture has a low resolution or is scaled.
  I also observe offsets in your images, I wonder if it might only be the width of the pen that is used by the renderer. Using a width of 1 instead of 2 might resolve the issue.
  Your solution adding 0.5 to the center position seems improper to me: there's no reason we should do that.

  R321 KStars

  sep-focus-improvements (branched from master)


To: murveit, mutlaqja, lancaster, TallFurryMan
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200416/a741b48e/attachment.html>

More information about the kde-edu mailing list