D28788: Option to acquire the guiding status from PHD2 to stay in sync

[Wolfgang Reissenberger]

wreissenberger created this revision.
wreissenberger added reviewers: mutlaqja, TallFurryMan, lancaster.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
wreissenberger requested review of this revision.

REVISION SUMMARY
  Due to concurrency in PHD2 it might happen, that a last guiding step is executed after a pause command has been successfully executed. This can create problems with the Guide module, since the Guide module assumes automatically being in state GUIDE_GUIDING if it sees a guiding step.
  To resolve this, the PHD2 module no longer guesses the state but it re-aquires it from PHD2.
  
  This method could be used in future in other situations as well. Due to try to avoid any regressions, I only resolved this single code place. If it turns out to be stable, we could refactor other places as well.

TEST PLAN
  This specific situation is difficult to test. Since a central method handling a received state information has been refactored, please test all situations where PHD2 changes its state.

REPOSITORY
  R321 KStars

BRANCH
  guide_paused_resume

REVISION DETAIL
  https://phabricator.kde.org/D28788

AFFECTED FILES
  kstars/ekos/guide/externalguide/phd2.cpp
  kstars/ekos/guide/externalguide/phd2.h
  kstars/ekos/guide/guide.cpp

To: wreissenberger, mutlaqja, TallFurryMan, lancaster
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200413/b1a0f89d/attachment.html>