D28689: Hotfixes for the Focus module

Eric Dejouhanet noreply at phabricator.kde.org
Wed Apr 8 23:13:33 BST 2020

TallFurryMan added a comment.

  A few things I wanted to add but will delay:
  - UI does not reflect the use of SEP and Centroid for initial detection, nor for full-field analysis.
  - Due to the first point, the tests are not properly verifying the Threshold and Gradient algorithms because the full-field analysis option is set!
  - UI does a weird toggle on the capture button when preparing the screen, and re-enables said button *before* the star extraction completes (that code block is tricky to refactor).
  - Due to the first point, the tests need to wait an arbitrary duration to verify the detection results.

  R321 KStars


To: TallFurryMan, #kstars, mutlaqja
Cc: kde-edu, mutlaqja, murveit, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200408/aa5b34aa/attachment.html>

More information about the kde-edu mailing list