D28477: Fixes a bug where the HFR was not displayed.

[Eric Dejouhanet]

TallFurryMan requested changes to this revision.
TallFurryMan added a comment.
This revision now requires changes to proceed.


  I'd like to see a unitary test for this. A simple thing that loads a star cluster fits generated with the CCD simulator, and runs a star detection using SEP. My differential uses UI tests, which are an entirely different method, possibly maybe useful for changes spanning multiple modules.
  
  What I'll do: I'll create a skeleton of unitary tests for this purpose, and create a test checking findSEPStars specifically with a test frame, and benchmark. Hy, you will then update your code and try your changes in the context of this test. Sounds possible?
  
  Integrating this to my differential is tricky because I moved code to other files. So I'd prefer this change be merged first (and tested) and myself doing the conflict management afterwards.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D28477

To: murveit, mutlaqja, TallFurryMan
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200405/9f295cf7/attachment.html>