D28489: digital electricity, movie config to activityConfig multiple dataset style

Johnny Jazeix noreply at phabricator.kde.org
Fri Apr 3 16:20:21 BST 2020


jjazeix added inline comments.

INLINE COMMENTS

> ActivityConfig.qml:24
> +import "../../core"
> +import "digital_electricity.js" as Activity
> +

not needed

> DigitalElectricity.qml:118
>              property real zoomLvl: 0.25
> +            property string mode
>          }

it would be better to have it just before the line of isTutorialMode so we group together the related information

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D28489

To: dekumar, jjazeix, #gcompris_improvements
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200403/2a5bf201/attachment.html>


More information about the kde-edu mailing list