D28489: digital electricity, movie config to activityConfig multiple dataset style

Johnny Jazeix noreply at phabricator.kde.org
Wed Apr 1 19:30:17 BST 2020


jjazeix added a comment.


  except a small change, looks good to me

INLINE COMMENTS

> DigitalElectricity.qml:117
>              property alias infoImage: infoImage
> -            property bool isTutorialMode: activity.isTutorialMode
>              property alias tutorialInstruction: tutorialInstruction

can you keep this variable? It avoids using everywhere a string that we may mistypo.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D28489

To: dekumar, jjazeix, #gcompris_improvements
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200401/02cb86e7/attachment.html>


More information about the kde-edu mailing list