D24151: Summary: Connect Scheduler sleep timer to Simulation Clock scale change.

Eric Dejouhanet noreply at phabricator.kde.org
Mon Sep 23 06:57:51 BST 2019

TallFurryMan added inline comments.


> mutlaqja wrote in simclock.cpp:185
> Why was this moved here? Was it tested for any regressions in KStars outside the scheduler?

Because sending the scale update to slots after setting the scale update in SimClock defeats the purpose of sending the scale update. Clients should be able to restore their "real" time values by de-scaling before using the new scale value, like I did in simClockScaleChanged. Else, clients need to store the current scale in order to restore their time values before using the new scale, which is cumbersome.

I verified no code was using the old version of the signal before fixing. Probably this small problem would have been fixed earlier had this signal been actually used in the code.

  R321 KStars

  feature__scheduler_synced_to_simulation (branched from master)


To: TallFurryMan, wreissenberger, mutlaqja, alexcherney
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190923/bbec84a5/attachment-0001.html>

More information about the kde-edu mailing list