D24152: Guiding Labels

[Jasem Mutlaq]

mutlaqja requested changes to this revision.
mutlaqja added a comment.
This revision now requires changes to proceed.


  Looking good, just simple i18n change.

INLINE COMMENTS

> guide.cpp:268
> +        northLabel->setColor(deLabelColor);
> +        northLabel->setText(i18n("N"));
> +        northLabel->position->setType(QCPItemPosition::ptViewportRatio);

Please use i18nc for context. i.e.

i18nc("North", "N")

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D24152

To: lancaster, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190923/952f3074/attachment.html>