D23892: Fix HFR calculation, add HFR on focus view, adjust focus UI.

[Wolfgang Reissenberger]

wreissenberger added a comment.


  Awesome job, Eric!
  
  I've tested it with simulators and everything looks good. Having the HFR-values displayed makes it much more transparent what the focusing algorithm does.
  
  Maybe one thing maybe needs some polishing. The idea with the tabs for Settings and Advanced are a good idea. I personally would place more parameters into the Settings tab and less under "Advanced".  I personally would opt having at least box size and step size under "Settings", maybe tolerance as well.
  
  But this fine tuning. I would publish this diff and issue the fine tuning later.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D23892

To: TallFurryMan, mutlaqja, alexcherney, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190915/f1de9ec1/attachment.html>