D23805: Restrict pausing to image capturing

Wolfgang Reissenberger noreply at phabricator.kde.org
Mon Sep 9 21:21:13 BST 2019


wreissenberger created this revision.
wreissenberger added reviewers: mutlaqja, TallFurryMan.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
wreissenberger requested review of this revision.

REVISION SUMMARY
  The capturing process can currently be paused at arbitrary stages, not only during capturing. This behavior cannot be covered by the current state model of the Capture module. But fixing this needs significant refactoring.
  
  As an intermediate solution, a warning is issued when the "Pause" button is pressed but no capture is running. If the Capture module is not in the capturing mode, pressing the pause button is ignored.

TEST PLAN
  Test pressing the pause button during a meridian flip or the post flip alignment. Without this fix, the Capture module gives the impression, that a pause is planned. But after completing the re-alignmelt after a meridian flip, capturing continues. With this fix, pausing is not possible until the Capture module is capturing frames.

REPOSITORY
  R321 KStars

BRANCH
  bug_pause_during_mf

REVISION DETAIL
  https://phabricator.kde.org/D23805

AFFECTED FILES
  kstars/ekos/capture/capture.cpp
  kstars/ekos/capture/capture.h

To: wreissenberger, mutlaqja, TallFurryMan
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190909/5a95b516/attachment.html>


More information about the kde-edu mailing list