D23762: Improving Astrometry Conf file support for Linux and OS X

[Robert Lancaster]

lancaster created this revision.
lancaster added a reviewer: mutlaqja.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
lancaster requested review of this revision.

REVISION SUMMARY
  This addresses a number of astrometry issues and adds functionality
  
  - The Astrometry Conf file option was being ignored on Linux so the user thought they were setting it but were not.
  - The internal conf file option is now available on Linux.  For awhile now, KStars on Linux has been using the internal conf file without permission
  - This update allows the conf file editor to now work on Linux too, which adds tons of flexibility.
  - Users can now create multiple directories for conf files wherever they choose
  - Users are now told beforehannd and are prevented from downloading files to nonexistant directories and directories that are read only.
  - Users can now specifically choose which directory index files are going into and get a report of what is installed on each
  - Users can also get a report of all index files installed in all directories
  - Adding/changing a directory now in the conf file is easier with a file browser.

TEST PLAN
  - Try creating a new installation on Mac and Linux with no conf file
  - Try adding other directories to the conf file both using the editor and the plus button in the conf file editor
  - Try changing other parameters in the conf file and saving.
  - Try selecting different locations in the index file downloader and downloading/deleting files
  - Try folders that don't actually exist to make sure it lets the user know and prevents the download
  - Try using the Internal Conf file and then try using an external one

REPOSITORY
  R321 KStars

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23762

AFFECTED FILES
  kstars/auxiliary/ksutils.cpp
  kstars/auxiliary/ksutils.h
  kstars/ekos/align/align.cpp
  kstars/ekos/align/offlineastrometryparser.cpp
  kstars/ekos/align/offlineastrometryparser.h
  kstars/ekos/align/opsalign.cpp
  kstars/ekos/align/opsastrometrycfg.cpp
  kstars/ekos/align/opsastrometrycfg.h
  kstars/ekos/align/opsastrometrycfg.ui
  kstars/ekos/align/opsastrometryindexfiles.cpp
  kstars/ekos/align/opsastrometryindexfiles.h
  kstars/ekos/align/opsastrometryindexfiles.ui

To: lancaster, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190907/2f0209c9/attachment.html>