D23717: Do not report guiding as started in PHD2::StartGuiding Event handler because it will start scheduled capture prematurely (before Settle is complete).

[Alex Cherney]

alexcherney created this revision.
alexcherney added a reviewer: KStars.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
alexcherney requested review of this revision.

REVISION SUMMARY
  I was shooting a large mosaic (64 panels) with 135mm lens guiding with PHD2 and Ekos and there was a problem where guiding would be reported as started before GuideSettle, resulting in lost guide star and other issues. I traced it down to StartGuiding event handler incorrectly emitting newStatus(GUIDE_GUIDING) which would immediately trigger the capture in scheduler. PHD2 will always send SettleDone and GUIDE_GUIDING should be set there to avoid that problem. I tested the change extensively using simulators and did not find any issues - all works as expected.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D23717

AFFECTED FILES
  kstars/ekos/guide/externalguide/phd2.cpp

To: alexcherney, #kstars
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190904/5960098d/attachment.html>