D23638: Fix build with cmake < 3.7

Wolfgang Bauer noreply at phabricator.kde.org
Sun Sep 1 12:45:20 BST 2019


wbauer created this revision.
wbauer added a reviewer: Rocs.
wbauer added a project: Rocs.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
wbauer requested review of this revision.

REVISION SUMMARY
  `VERSION_GREATER_EQUAL was introduced in cmake 3.7, but the specified minimum version is 3.3.
  So use `NOT VERSION_LESS` instead to still support older cmake versions too.

TEST PLAN
  rocs master builds fine with cmake 3.5.2 now, and also newer versions (haven't tried older versions).
  
  Before, I got this error when using cmake 3.5.2:
  
    CMake Error at CMakeLists.txt:85 (if):
      if given arguments:
    
        "KF5Declarative_VERSION" "VERSION_GREATER_EQUAL" "5.45"
    
      Unknown arguments specified

REPOSITORY
  R73 Rocs

REVISION DETAIL
  https://phabricator.kde.org/D23638

AFFECTED FILES
  CMakeLists.txt

To: wbauer, #rocs
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190901/a5d63255/attachment.html>


More information about the kde-edu mailing list