D25060: Fixing ASTAP Path on OS X and Setting Autostar as default for PHD2 Guiding

[Robert Lancaster]

lancaster created this revision.
lancaster added a reviewer: mutlaqja.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
lancaster requested review of this revision.

REVISION SUMMARY
  1. Fixing the default path for ASTAP on os x.
  2. Checking the "auto star" checkbox when a user connects to PHD2 regardless of what they previously did.
  3. Checking the "auto star" checkbox after a meridian flip
  4. Moving the Meridian flip code that affects guiding to the guider where it makes more sense.
  
  The auto-star changes were necessary because users reported that when using Ekos remotely controlling PHD2, but not using the autostar option,
  after a meridian flip, the previously selected lock position is of course no longer valid, but Ekos still tries to make it use the previously selected star which moved.
  So rather than trying to calculate the new star position based on a previously selected guide star, I believe it is better to just let
  PHD2 automatically select a star if doing an automated meridian flip.  If the user desires to choose a different guide star, then the user can uncheck the box and do so in Ekos,
   or even use the PHD2 interface to do so.  But when it is automated, it is best to keep it as automated as possible.

REPOSITORY
  R321 KStars

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25060

AFFECTED FILES
  kstars/auxiliary/ksutils.cpp
  kstars/ekos/guide/guide.cpp
  kstars/ekos/guide/guide.h
  kstars/ekos/manager.cpp

To: lancaster, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191029/a8c69291/attachment.html>