D24930: Fix warnings "implicitly-declared Rect& Rect::operator=(const Rect&) is deprecated" from GCC 9
Yuri Chornoivan
noreply at phabricator.kde.org
Thu Oct 24 20:13:29 BST 2019
yurchor added a comment.
In D24930#553628 <https://phabricator.kde.org/D24930#553628>, @aacid wrote:
> this is a tricky one, on one hand, yes this fixes the warning and behaves like it used to, so that's "good"
>
> On the other hand introduces an imbalance in which the copy constructor calls normalize but the assignment operator doesn't, think that's "bad"
>
> What do you think about actually implementing the operator= and calling normalize in it?
I might be wrong, but does the usage of normalize() in all constructors imply that it is impossible to assign "unnormalized" Rects?
REPOSITORY
R331 Kig
REVISION DETAIL
https://phabricator.kde.org/D24930
To: yurchor, #kde_edu
Cc: aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191024/34209c4d/attachment.html>
More information about the kde-edu
mailing list