D25497: Fix bug re filter-change-autofocus

Hy Murveit noreply at phabricator.kde.org
Sun Nov 24 20:34:31 GMT 2019


murveit added a comment.


  That's true, though, as far as I know, that shouldn't happen.
  
  To be more defensive against missed messages, I could add a method to FilterManager that directly access its state (e.g. FilterManager::getState() { return state; } and query that here instead of checking the Capture class variable filterState. However, I coded this to match the current style used in capture.cpp. That is, we already have and check  focusState, guideState & alignState, and I believe your comment equally applies to those. Let me know your preference. Also, let me know if you'd like me to add a appendLogText() while it's waiting (though it would append that every second that it waits).

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D25497

To: murveit, mutlaqja, wreissenberger, lancaster
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191124/c496a7be/attachment.html>


More information about the kde-edu mailing list