D25497: Fix bug re filter-change-autofocus

[Hy Murveit]

murveit created this revision.
murveit added reviewers: mutlaqja, wreissenberger, lancaster.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
murveit requested review of this revision.

REVISION SUMMARY
  Added a test in Capture::captureImage() that checks to see if the filterManager is busy,
  and if so, waits until it isn't. This resolves and issue where the focus and capture modules
  could both be trying to take pictures, if auto-focus-on-filter-change is set, and if a filter
  is changed mid-sequence, e.g. by a meridian flip causing align to run, which may run with a different filter.
  
  Disabled auto-focus-on-filter-change for alignment. This wasn't 100% necessary to fix the above bug,
  but I believe it is the right thing to do. Without this, align is likely to initiate an autofocus,
  when the auto-focus-on-filter-change option is set, and then, after control passes back to capture,
  another auto-focus would likely be run. Seems over the top.

REPOSITORY
  R321 KStars

BRANCH
  filter-autofocus-bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25497

AFFECTED FILES
  kstars/ekos/align/align.cpp
  kstars/ekos/auxiliary/filtermanager.h
  kstars/ekos/capture/capture.cpp
  kstars/ekos/capture/capture.h

To: murveit, mutlaqja, wreissenberger, lancaster
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191123/e17de36b/attachment-0001.html>