D25405: Fix Step infobrowser and examples localization

Andreas Cord-Landwehr noreply at phabricator.kde.org
Tue Nov 19 17:47:03 GMT 2019


cordlandwehr added inline comments.

INLINE COMMENTS

> infobrowser.cc:158
> +        if(fileName.isEmpty()) {
> +            fileName = QStandardPaths::locate(QStandardPaths::DataLocation, QStringLiteral("objinfo/%1.html").arg(className.toLower()));
> +        }

In my opinion, I would prefer to stick with the resource-based location for the un-translated HTML files. This makes the development setup (slightly) simpler because no XDG_DATA_DIRS variable must be set and the default handling is easier to break. Actually, the default HTML files would be a fallback even if the environment variables are set incorrectly.

REPOSITORY
  R341 Step

REVISION DETAIL
  https://phabricator.kde.org/D25405

To: yurchor, #kde_edu, #localization
Cc: cordlandwehr, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191119/0cb5e3bf/attachment-0001.html>


More information about the kde-edu mailing list