D25133: Handle guiding problems during dithering

[Wolfgang Reissenberger]

wreissenberger created this revision.
wreissenberger added reviewers: mutlaqja, lancaster.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
wreissenberger requested review of this revision.

REVISION SUMMARY
  This is an extension of the diff D25105 <https://phabricator.kde.org/D25105>.
  
  When a guiding problem occurs during dithering, the schedule does not restart guiding and capturing. This happens only in the case that the capture sequence has a delay > 0 defined. The reason is that both the Scheduler and the Capture module try to restart capturing, which ends up the Capture module in the wait state.
  
  With this diff, the Capture module resumes capturing after dithering only if no problems occured. If a problem occurs, capturing aborts which leaves it to the Scheduler to restart capturing.

TEST PLAN
  Enable dithering in the guiding module. Start a schedule with a capture sequence that has multiple captures and uses guiding. Start the schedule and interrupt guiding during dithering.
  
  Execute this for all combinations of "Abort Autoguiding on failure" set or unset as well as having a delay > 0 set in the capture sequence or not.

REPOSITORY
  R321 KStars

BRANCH
  scheduler_restart_guiding_dithering_errors

REVISION DETAIL
  https://phabricator.kde.org/D25133

AFFECTED FILES
  kstars/ekos/capture/capture.cpp

To: wreissenberger, mutlaqja, lancaster
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191103/f5d7b6ef/attachment.html>