D25110: Ensure that guiding is running when capture is started
Eric Dejouhanet
noreply at phabricator.kde.org
Sat Nov 2 10:22:32 GMT 2019
TallFurryMan added inline comments.
INLINE COMMENTS
> scheduler.cpp:2154
>
> -#if 0
> - // Advices
Thus advice block is actually sound, but there was not enough tests done to include it.
> scheduler.cpp:2711
> -
> -#if 0
> - // Check if mount and dome support parking or not.
OK this is code that was moved.
> scheduler.cpp:3507
> break;
> -#if 0
> - case SchedulerJob::STAGE_FOCUSING:
OK this is code that was moved.
> scheduler.cpp:4537
>
> + // ensure that guiding is running before we start capturing
> + if (currentJob->getStepPipeline() & SchedulerJob::USE_GUIDE && getGuidingStatus() != GUIDE_GUIDING)
This is actually the diff. OK.
> scheduler.cpp:4863
> // Scheduler always sets captured frame map when starting a sequence - count may be different, robustness, dynamic priority
> -#if 0
> - // JM 2018-09-24: If job is looping, no need to set captured frame maps.
OK dead code.
> scheduler.cpp:4892
>
> - // Never ignore sequence history in the Capture module, it is unrelated to storage
> -#if 0
OK.
REPOSITORY
R321 KStars
REVISION DETAIL
https://phabricator.kde.org/D25110
To: wreissenberger, mutlaqja, lancaster, TallFurryMan
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191102/db5bc508/attachment.html>
More information about the kde-edu
mailing list