D25105: Dithering while crossing the meridian recognized as guiding

[Wolfgang Reissenberger]

wreissenberger created this revision.
wreissenberger added reviewers: mutlaqja, lancaster.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
wreissenberger requested review of this revision.

REVISION SUMMARY
  Restarting guiding after a meridian flip currently currently only happens, when the guider is in the guiding mode. For example, in the case that the meridian is crossed while dithering, the capture module does not recognize this as part of the guiding procedure and hence does not restart guiding as soon as the meridian flip is finished. This change fixes this and considers dithering, but also re-acquiring and calibrating as an indication that guiding should resume after meridian flip.
  
  Additionally, a possible a weakness that may cause null pointer exceptions in starting focus execution is fixed. And last but not least, some dead code has been eliminated.

TEST PLAN
  Enable dithering, move the scope close but east of the meridian and start a capturing sequence. In order to ensure, that the meridian is crossed while dithering, run kstars inside the debugger and set a breakpoint before the call of dithering. Check, if after the meridian flip guiding is restarted.

REPOSITORY
  R321 KStars

BRANCH
  meridian_flip_bugfix_restart_guiding

REVISION DETAIL
  https://phabricator.kde.org/D25105

AFFECTED FILES
  kstars/ekos/capture/capture.cpp
  kstars/ekos/capture/capture.h

To: wreissenberger, mutlaqja, lancaster
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191101/9288468b/attachment.html>