D21212: Remove DBus from Python backend

Nikita Sirgienko noreply at phabricator.kde.org
Sat May 18 17:26:57 BST 2019

sirgienko added inline comments.


> asemke wrote in pythonexpression.cpp:133
> what happens if we have two images from two expressions and they arrive at the wrong order (second image is faster than the first one)?

All will worked, because each expressions have own m_tempFile.

> asemke wrote in pythonservermain.cpp:24
> Are QTextStream and QChar really required in this file?

QTextStream no needed, but QChar used in `recordSep`, `unitSep`. Though, maybe i could change it to `char`.

> asemke wrote in pythonsession.cpp:141
> use c++11 range based loop instead of the foreach macro.


> asemke wrote in pythonvariablemodel.cpp:49
> is this int variable still required in the new code?

You right, the variable not needed, I just had forggoten to remove it.

  R55 Cantor


To: sirgienko, asemke
Cc: kde-edu, asemke, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190518/e617f320/attachment-0001.html>

More information about the kde-edu mailing list