D17180: Fix faulty number of new words counting
Albert Astals Cid
noreply at phabricator.kde.org
Thu May 16 22:16:24 BST 2019
aacid added inline comments.
INLINE COMMENTS
> hriesenbeck wrote in sessionmanagerfixedtest.cpp:215
> This writes to parleys config file. If this is not allowed in automated testing, the sub test for conjugation practice mode has to be removed.
> The writing to config file is necessary because parley EntryFilter class loads the document specific preferences from disk. The tenses for conjugation practice are document specific and needed for this test.
right, changing peoples config when running tests is bad, but this should be hopefully be fixed by calling
QStandardPaths::setTestModeEnabled(true);
in initTestCase.
Should the same be done for testentrytest.cpp ?
REPOSITORY
R340 Parley
REVISION DETAIL
https://phabricator.kde.org/D17180
To: hriesenbeck, #kde_edu
Cc: aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190516/8b13c56c/attachment.html>
More information about the kde-edu
mailing list