D17180: Fix faulty number of new words counting

Hartmut Riesenbeck noreply at phabricator.kde.org
Sun May 5 20:59:15 BST 2019


hriesenbeck updated this revision to Diff 57609.
hriesenbeck added a comment.


  - Autotests for bugfix were added
  
  TestEntryTest is checking the new added methods in parles TestEntry
  class. Because the behaviour of the new methods depends on parleys
  current practice mode, the methods are called in all affected practice
  modes.
  
  SessionManagerFixedTest is aimed on the bug. The test is failing with
  current master checkout and succeeding after applying the bugfix.
  
  During the creation of the unit tests a failure in the bugfix showed
  up and was corrected.
  
  Unnecessary debug output, which disturbed the unit test output was
  commented out.

REPOSITORY
  R340 Parley

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17180?vs=46290&id=57609

BRANCH
  fix_max_number_of_new_words_for_review (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17180

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/sessionmanagerfixedtest.cpp
  autotests/sessionmanagerfixedtest.h
  autotests/testentrytest.cpp
  autotests/testentrytest.h
  src/collection/entryfilter.cpp
  src/collection/testentry.cpp
  src/collection/testentry.h
  src/practice/sessionmanagerbase.cpp
  src/practice/sessionmanagerfixed.cpp

To: hriesenbeck, #kde_edu
Cc: aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190505/d574dfbc/attachment-0001.html>


More information about the kde-edu mailing list