D21014: Replace importFile LineEdit with KUrlComboBox to save the paths to the last imported files

[Alexander Semke]

asemke added inline comments.

INLINE COMMENTS

> ImportFileWidget.cpp:175
> +	auto* gridLayout = dynamic_cast<QGridLayout*>(ui.gbDataSource->layout());
> +	if (gridLayout) {
> +		gridLayout->addWidget(m_cbFileName, 1, 2, 1, 3);

no brackets for one-liners

> ImportFileWidget.cpp:1213
> +	QString tempFileName = fileName();
> +	QString fileName = absolutePath(tempFileName);
>  	AbstractFileFilter::FileType fileType = currentFileType();

we don't really need this temp variable. Let's do it directly with QString fileName = absolutePath(fileName());

> ImportFileWidget.h:108
>  	QTableWidget* m_twPreview;
> +	KUrlComboBox* m_cbFileName;
>  	const QString& m_fileName;

let's add default initialization here - KUrlComboBox* m_cbFileName{nullptr};

> ImportFileWidget.h:128
>  	void refreshPreview();
> +	void importUrlChanged(const QUrl url);
>  

const QUrl&

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D21014

To: Murmele, asemke
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190504/db63bd2a/attachment.html>