D20953: New Home Screen for KTouch

[Sebastian Gottfried]

gottfried marked an inline comment as done.
gottfried added a comment.


  In D20953#460428 <https://phabricator.kde.org/D20953#460428>, @ognarb wrote:
  
  > In D20953#459771 <https://phabricator.kde.org/D20953#459771>, @gottfried wrote:
  >
  > > In D20953#459468 <https://phabricator.kde.org/D20953#459468>, @ognarb wrote:
  > >
  > > > Hi, not a KTouch dev, but I found a typo. ;)
  > >
  > >
  > > Yay, I'm basically the only one developing features for KTouch. I still value review for non-trivial changes, though.
  >
  >
  > :) So I tried it on my machine on it worked very well. :) Can't really comment about the code but found the sidebar shadow a bit strange. The shadow gave me the wrong impression that the sidebar is collapsible. Maybe you could ask the VDG for feedback. Otherwise, the UI looks great.
  
  
  Thank you. I can see your point. I have added the shadow as visual separator between the sidebar and the lesson grid. I agree its a bit misleading. Maybe the VDG has a better idea.

REPOSITORY
  R336 KTouch

REVISION DETAIL
  https://phabricator.kde.org/D20953

To: gottfried, #kde_edu
Cc: ognarb, kde-edu, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190504/33a689c1/attachment.html>