D20001: Simplifying Scheduler

[Wolfgang Reissenberger]

wreissenberger created this revision.
wreissenberger added reviewers: mutlaqja, TallFurryMan.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
wreissenberger requested review of this revision.

REVISION SUMMARY
  Currently, the scheduler is a class with more than 7200 lines of code which makes it very tricky to maintain. This approach follows the idea to create a separate class ScheduleStrategy that holds the entire logic to select a certain schedule to be executed.
  
  As a first step, the scoring calculation is extracted and shifted to ScheduleStrategy.

TEST PLAN
  Well, this is the downside of this refactoring effort. Since the Scheduler is awfully complex and intertwined, it needs to be tested carefully.
  
  At least from the intention, the execution of scheduler jobs should not be touched, only the correct calculations of scores. So please test all combinations that have effect to the score of a scheduler job.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D20001

AFFECTED FILES
  kstars/CMakeLists.txt
  kstars/ekos/scheduler/scheduler.cpp
  kstars/ekos/scheduler/scheduler.h
  kstars/ekos/scheduler/schedulerjob.cpp
  kstars/ekos/scheduler/schedulestrategy.cpp
  kstars/ekos/scheduler/schedulestrategy.h

To: wreissenberger, mutlaqja, TallFurryMan
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190323/9ad2271a/attachment.html>