D19998: Remove bypass of preliminary steps when no light frames are needed.

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  When Scheduler executes a sequence file which contains no light frames, it bypasses preliminary steps such as tracking, focusing, aligning and guiding.
  
  This differential removes this bypass, considering:
  
  - Unticking all preliminary steps from the schedule job offers identical behavior.
  - Automatic calibration of exposure duration by the Capture module, using flat frames as light frames, is an interesting feature.
  - The feature is confusing for end-users.
  
  Note that per original behavior, the Scheduler will still bypass opening the dome and avoid sleeping when only calibration frames are to be processed.
  
  Discussion is at https://www.indilib.org/forum/development/4882-calibration-frames-optimized-step-from-the-scheduler.html

TEST PLAN
  Simple workflow with only light frames is undisturbed.
  Simple workflow with only calibration frames is now able to track an arbitrary target, focus, align and guide, all of which are useless for real flat frames.
  Observe as Wall Slewing option of calibration frames is now in conflict with tracking and guiding steps.
  Guiding, especially, will abort the scheduler job when slewing to the Wall coordinates.

REPOSITORY
  R321 KStars

BRANCH
  improve__remove_calibration_frame_bypass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19998

AFFECTED FILES
  kstars/ekos/scheduler/scheduler.cpp

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190323/6ff5e4b3/attachment.html>