D19774: Use ellipsis in search field

[Albert Astals Cid]

aacid added a comment.


  In D19774#433207 <https://phabricator.kde.org/D19774#433207>, @ognarb wrote:
  
  > In D19774#433205 <https://phabricator.kde.org/D19774#433205>, @aacid wrote:
  >
  > > I wish you used proper commit logs, this is not "Use ellipsis in the search field" this is "Remove search label and replace it by a placeholder"
  > >
  > > You may not think of it, but this commit logs are going to be read by people in 10 years and them being accurate is quite important.
  >
  >
  > Sorry about that, I will use better titles in the future.
  >
  > > And also, stop removing buddies! You're making the line edits inaccessible by using the keyboard when before they were, that's a major usability regression
  >
  > I don't understand the problem, I can still use tab to go to the line edit. Or are they some other shortcuts that I don't know yet?
  
  
  Buddies are not about tabbing, buddies are keyboard accelerators. See https://i.imgur.com/ztGaCW5.gif
  
  It's a bit basic, but pressing Alt+H will focus the buddy of the Hello label and pressing Alt+T will focus the buddy of the There label. If you remove the labels you can't Alt+Anything to focus on the line edits

REPOSITORY
  R326 Kalzium

REVISION DETAIL
  https://phabricator.kde.org/D19774

To: ognarb, #kalzium, #vdg, yurchor
Cc: aacid, yurchor, ngraham, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190317/d39538fe/attachment-0001.html>