D19840: Bugfix: proper usage of abort() for finishing a capture sequence queue

[Wolfgang Reissenberger]

wreissenberger created this revision.
wreissenberger added reviewers: mutlaqja, TallFurryMan.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
wreissenberger requested review of this revision.

REVISION SUMMARY
  Before diff D19528 <https://phabricator.kde.org/D19528>, abort events in the capture module where not always communicated to the scheduler. As a result, an aborted guiding was never restarted and brought the scheduler and the capture module out of sync. The scheduler thought that the capture was running while it already had been aborted.
  
  Unfortunately, the Capture::abort() function is also used for properly terminating a capture session. If a capture session has been completed, stop() is called and then abort(), resulting in an unexpected abort event in the scheduler.
  
  If a scheduler restarts a capture session, this abort event from the previous run leads to the situation, that Capture::start() is called twice, which leads to the situation that the first entry of the capture sequence is skipped.

TEST PLAN
  - Create a capture session with at least two entries.
  - Create a schedule that uses this session and runs at least twice.
  - Start the schedule and check, whether in the second run of the capture session all session entries are executed properly. Without this diff, the first session entry is skipped except for the first run. With this diff, everything should work properly.

REPOSITORY
  R321 KStars

BRANCH
  bugfix_capture_completion

REVISION DETAIL
  https://phabricator.kde.org/D19840

AFFECTED FILES
  kstars/ekos/capture/capture.cpp

To: wreissenberger, mutlaqja, TallFurryMan
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190317/35a09112/attachment.html>