D19645: Deprecating rotation function

[Tomaz Canabrava]

tcanabrava added a comment.


  In D19645#428711 <https://phabricator.kde.org/D19645#428711>, @apol wrote:
  
  > That's not how we deprecate in C++.
  >
  > You'll want to use ANALITZAPLOT_DEPRECATED_EXPORT on the method declaration.
  
  
  Well, it kinda is (as it's a new way to deprecate methods in C++ since C++14)
  https://en.cppreference.com/w/cpp/language/attributes/deprecated
  
  The actual error is that she added this to the cpp instead of the header. Also, grepping for DEPRECATED on kalgebra / analitza only showted ANALITZAWIDGETS_DEPRECATED_EXPORT, but no define. is this generated by CMake ?

REPOSITORY
  R323 Analitza

REVISION DETAIL
  https://phabricator.kde.org/D19645

To: karinapassos, tcanabrava, apol, #kde_edu
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190311/beb4f516/attachment.html>