D19095: Adding new Variable models for few backends

Nikita Sirgienko noreply at phabricator.kde.org
Sun Mar 10 10:13:14 GMT 2019


sirgienko marked 8 inline comments as done.
sirgienko added inline comments.

INLINE COMMENTS

> asemke wrote in maximavariablemodel.cpp:151
> m_variableExpression seems to exist in MaximaVariableModel only. Should we define it as MaximaExpression and avoid this cast?

I have done it. But it doesn't bring big difference, because we still need casting for  `Cantor::Expression` from `evaluateExpression` to `MaximaExpression`.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D19095

To: sirgienko, asemke
Cc: kde-edu, asemke, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190310/8101417e/attachment.html>


More information about the kde-edu mailing list