D17945: Tutorial screen added for odd even activity

Albert Astals Cid noreply at phabricator.kde.org
Tue Mar 5 20:03:58 GMT 2019


aacid added inline comments.

INLINE COMMENTS

> Tutorial1.qml:33
> +        id: remainder
> +        text: qsTr("The remainder is the amount \"left over\" after dividing the given number with the other number.\n " +
> +                   " If 6 is divided by 2 the result is 3 and the remainder is 0.\n " +

Don't use + for concatenating strings that go on qsTr i'm 96% sure this breaks translations.

> Tutorial2.qml:34
> +        text: qsTr("For example: 12, 38, 52, 68, 102, 118, 168, 188, 502, 532, 700, 798, 842, 892, 1000. " +
> +                   "All of these numbers are even numbers as they leave remainder 0 when divided by 2.")
> +        fontSizeMode: Text.Fit

same comment about qsTr and using +

> Tutorial3.qml:33
> +        id: odd
> +        text: qsTr("For example: 15, 19, 51, 65, 103, 119, 169, 185, 505, 533, 701, 799, 845, 897, 1001. " +
> +                   " All of these numbers are odd numbers as they do not leave remainder 0 when divided by 2.")

same

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17945

To: dekumar, #gcompris_improvements, jjazeix
Cc: aacid, echarruau, amankumargupta, jjazeix, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190305/345a57e5/attachment-0001.html>


More information about the kde-edu mailing list