D21893: magic-hat, add multiple datasets

Johnny Jazeix noreply at phabricator.kde.org
Thu Jun 27 16:05:35 BST 2019


jjazeix added inline comments.

INLINE COMMENTS

> magic-hat.js:77
> +        setCoefficientVisibility(false)
> +        setWantedColor()
> +    } else {

is it needed? If no args, it does nothing?

> magic-hat.js:168
> +        nbStarsToCount[2] * questionCoefficients[2];
> +        if(starsCalculatedByUser ==  actualNumberOfStars)
> +            items.bonus.good("flower")

2 spaces after ==

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D21893

To: AkshayCHD, #gcompris_improvements, timotheegiet, amankumargupta, scagarwal
Cc: scagarwal, jjazeix, amankumargupta, timotheegiet, #gcompris_improvements, kde-edu, #gcompris, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, apol, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190627/c1122750/attachment-0001.html>


More information about the kde-edu mailing list