D21893: magic-hat, add multiple datasets

Johnny Jazeix noreply at phabricator.kde.org
Sun Jun 23 07:59:44 BST 2019

jjazeix added inline comments.


> StarsBar.qml:49
> +            visible: item.coefficientVisible
> +            text: qsTr(item.coefficient.toString() + "  x")
> +            fontSizeMode: Text.HorizontalFit

use .arg() for translation, on some locale, it may not be "3 x" but "3x" or even "x3" or not x at all.
There are also 2 spaces, I think it's 0 in English.

> Data.qml:28
> +    difficulty: 4
> +    property var range: 100
> +    data: [

if it's always an int, use int as type. Note that a range is usually two bounds, not a single number, it's more a maxValue here

  R2 GCompris


To: AkshayCHD, #gcompris_improvements, timotheegiet, amankumargupta
Cc: jjazeix, amankumargupta, timotheegiet, #gcompris_improvements, kde-edu, #gcompris, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, scagarwal, apol, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190623/dba9fc21/attachment-0001.html>

More information about the kde-edu mailing list