D22010: Fix problems when automatically recalcuating columns

Stefan Gerlach noreply at phabricator.kde.org
Sat Jun 22 19:46:34 BST 2019


sgerlach added inline comments.

INLINE COMMENTS

> Spreadsheet.cpp:676
> +		if (col->columnMode() != AbstractColumn::Numeric)
> +			col->setColumnMode(AbstractColumn::Numeric); // wieso??
> +

in english: "why?"

> FunctionValuesDialog.cpp:363
>  
> +//	if (m_spreadsheet->rowCount() != maxRowCount) // if to many rows, delete to save memory
> +//		m_spreadsheet->setRowCount(maxRowCount);

to -> too

> FunctionValuesDialog.cpp:367
>  	//resize the spreadsheet if one of the data vectors from other spreadsheet(s) has more elements then the current spreadsheet.
> -	if (m_spreadsheet->rowCount() < maxRowCount)
> +	if (m_spreadsheet->rowCount() > maxRowCount) // if to many rows, delete to save memory
>  		m_spreadsheet->setRowCount(maxRowCount);

to -> too

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D22010

To: Murmele, asemke
Cc: sgerlach, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190622/1ea3913b/attachment.html>


More information about the kde-edu mailing list