D21710: Add multiple datasets to smallnumbers activity

[Johnny Jazeix]

jjazeix added a comment.


  Good job for the activities.
  There is an issue when running gletters or wordsgame:
  qrc:/gcompris/src/activities/gletters/Gletters.qml:89: TypeError: Type error
  
  There has been some improvements in the multiple_dataset branch, for example adding the ChooseLevelDialog in the activities themselves. Feel free to merge it when you think it won't be too much of a rework and you have time.

INLINE COMMENTS

> Data.qml:26
> +Dataset {
> +    objective: qsTr("Select number on dice up to 7")
> +    difficulty: 2

smallnumbers2 is with dominoes

> Data.qml:27
> +    objective: qsTr("Select number on dice up to 7")
> +    difficulty: 2
> +    data: [

be sure the diff is the same as in the code, this is missing in the repo and causes:
qrc:/gcompris/src/core/DialogChooseLevel.qml:277:33: QML Image: Cannot open: qrc:/gcompris/src/core/resource/difficulty0.svg

> AkshayCHD wrote in Wordlist.qml:108
> @jjazeix I created a separate function for loading wordlist from a JSON object as function overloading is not possible in javascript https://www.codeproject.com/Articles/797997/JavaScript-Does-NOT-Support-Method-Overloading-Tha . Is this okay ?

yes, sure

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D21710

To: AkshayCHD, #gcompris_improvements
Cc: jjazeix, #gcompris_improvements, kde-edu, #gcompris, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190615/a0849af6/attachment.html>