D21710: Add multiple datasets to smallnumbers activity
Johnny Jazeix
noreply at phabricator.kde.org
Fri Jun 14 09:26:17 BST 2019
jjazeix added inline comments.
INLINE COMMENTS
> Wordlist.qml:108
> + // If levels are provided explicitly as function parameter, use them as wordlist
> + if(levels !== undefined) {
> + var levelsObject = {levels: levels}
I would separate it in an overriden function, both code are totally unrelated
REPOSITORY
R2 GCompris
REVISION DETAIL
https://phabricator.kde.org/D21710
To: AkshayCHD, #gcompris_improvements
Cc: jjazeix, #gcompris_improvements, kde-edu, #gcompris, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190614/306eb169/attachment.html>
More information about the kde-edu
mailing list