D20953: New Home Screen for KTouch

[Albert Astals Cid]

aacid added a comment.


  Loooks good.
  
  There's a few relative scary warnings though
  
  qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:367:25: QML LearningProgressChart: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
  qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:286:21: QML Label: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
  qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:293:21: QML ComboBox: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
  qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:306:21: QML Label: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
  qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:316:21: QML ComboBox: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
  qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:337:21: QML LegendItem: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
  qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:345:21: QML LegendItem: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
  qrc:/ktouch/qml/scorescreen/ScoreScreen.qml:162:17: QML IconToolButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
  qrc:/ktouch/qml/homescreen/ProfileSelector.qml:90: TypeError: Cannot read property 'isNewButton' of null
  
  have you seen this?

REPOSITORY
  R336 KTouch

REVISION DETAIL
  https://phabricator.kde.org/D20953

To: gottfried, #kde_edu, #vdg
Cc: aacid, ognarb, kde-edu, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190609/3c71dff6/attachment.html>