D21461: Multiplle datasets for money activity

[Sagar Chand Agarwal]

scagarwal requested changes to this revision.
scagarwal added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> money.js:26
>  
> +.import "moneyConstants.js" as Constants
> +

Do rename `Constants` as `moneyConstants`. Clear names are much better.

> Data.qml:24
> +import "../../../../core"
> +import "../../../money/moneyConstants.js" as Constants
> +

Same `Constants` . Do rename to `moneyConstants`

> Data.qml:24
> +import "../../../../core"
> +import "../../../money/moneyConstants.js" as Constants
> +

`moneyConstants` reference

> Data.qml:24
> +import "../../../../core"
> +import "../../../money/moneyConstants.js" as Constants
> +

moneyConstants reference

> Data.qml:24
> +import "../../../../core"
> +import "../../../money/moneyConstants.js" as Constants
> +

moneyConstants reference

> Data.qml:24
> +import "../../../../core"
> +import "../../../money/moneyConstants.js" as Constants
> +

`moneyConstants` reference

> Data.qml:24
> +import "../../../../core"
> +import "../../../money/moneyConstants.js" as Constants
> +

`moneyConstants` reference

> Data.qml:24
> +import "../../../../core"
> +import "../../../money/moneyConstants.js" as Constants
> +

`moneyConstants` reference

> Data.qml:24
> +import "../../../../core"
> +import "../../../money/moneyConstants.js" as Constants
> +

`moneyConstants` reference

> Data.qml:24
> +import "../../../../core"
> +import "../../../money/moneyConstants.js" as Constants
> +

`moneyConstants` reference

> Data.qml:24
> +import "../../../../core"
> +import "../../../money/moneyConstants.js" as Constants
> +

`moneyConstants` reference

> Data.qml:24
> +import "../../../../core"
> +import "../../../money/moneyConstants.js" as Constants
> +

`moneyConstants` reference

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D21461

To: AkshayCHD, #gcompris_improvements, scagarwal
Cc: scagarwal, asagtani, jjazeix, kde-edu, #gcompris_improvements, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190607/8bd99ee0/attachment-0001.html>