D22556: Headers of parent class GeneralTest and child class HypothesisTest

Stefan Gerlach noreply at phabricator.kde.org
Fri Jul 19 20:40:45 BST 2019


sgerlach added a comment.


  looks good so far.

INLINE COMMENTS

> GeneralTest.h:112
> +    QVBoxLayout* m_summaryLayout{nullptr};
> +    QLabel* m_resultLine[10];
> +    QMap<QString, QString> m_tooltips;

please use a global constant instead of 10. That makes it easier to extend it when needed.

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D22556

To: devanshuagarwal, sgerlach, asemke
Cc: kde-edu, #labplot, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190719/835df171/attachment-0001.html>


More information about the kde-edu mailing list