D22380: Reset autofocus when executing a job, so that focus step is applied properly when checked.
Eric Dejouhanet
noreply at phabricator.kde.org
Wed Jul 10 15:37:27 BST 2019
TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.
REVISION SUMMARY
When executing a sequence, the first job having the focus step checked was executing a focus procedure.
Once the focus procedure was done, no further focus procedure would be requested by Scheduler.
With this change, Scheduler always requests a focus procedure when a job explicitly requires it.
If the focus procedure needs to be run periodically, its period must be set in the capture sequence, and the Focus step unchecked.
TEST PLAN
The test can be run with the Simulator profile. Focus procedure will sometimes abort, but most of the time succeed.
Create a schedule plan with three targets with only Track and Focus checked, and short capture, and start Scheduler.
Scheduler runs the first job, slews to target and executes the focus procedure before capturing.
Scheduler shifts to the second job, slew to target, and:
- without this change, proceeds to capture even though the Focus step is checked.
- with this change, executes the focus procedure prior to capture.
Situation is the same for all subsequent jobs.
REPOSITORY
R321 KStars
BRANCH
bugfix__autofocus_inhibited (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D22380
AFFECTED FILES
kstars/ekos/scheduler/scheduler.cpp
To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190710/f13310af/attachment.html>
More information about the kde-edu
mailing list