D22200: Column observer

[Alexander Semke]

asemke added inline comments.

INLINE COMMENTS

> CMakeLists.txt:185
>  	${BACKEND_DIR}/core/Workbook.cpp
> +    ${BACKEND_DIR}/core/ColumnObserver.cpp
>  	${BACKEND_DIR}/core/AspectTreeModel.cpp

indentation.

> AspectTreeModel.cpp:197
> +				if (m_showPlotDesignation)
> +					name += QLatin1Char('\t') + " " + column->plotDesignationString();
>  

what is the advantage of moving this code to Column? I don't think the code is more compact now because of this change and you also need to implement the function in AbstractSimpleFilter.

> ColumnObserver.cpp:25
> +
> +void ColumnObserver::columnRemoved(const AbstractColumn* column) {
> +

if we don't need this function now, let's remove it. We can add it once we really need it.

> Project.cpp:208
> +		const AbstractColumn* column = dynamic_cast<const AbstractColumn*>(aspect);
> +		if (column) {
> +			columnObserver->descriptionChanged(column);

no brackets here.

> Project.cpp:220
> +	const AbstractColumn* column = dynamic_cast<const AbstractColumn*>(aspect);
> +	if (column) {
> +		columnObserver->columnAdded(column);

no brackets here.

> Project.cpp:225
> +
> +void Project::aspectRemovedSlot(const AbstractAspect* aspect) {
> +	const AbstractColumn* column = dynamic_cast<const AbstractColumn*>(aspect);

doesn't have any affect. Can be also removed I guess.

> Project.cpp:227
> +	const AbstractColumn* column = dynamic_cast<const AbstractColumn*>(aspect);
> +	if (column) {
> +		columnObserver->columnRemoved(column);

no brackets for one-liners.

> XYCurveDock.cpp:507
> +	} else
> +		cbXColumn->setInvalid(true, i18n("The column")+ " \""+ m_curve->xColumnPath() + "\"\n"+ i18n("is not available. If a new column at this path is created, it is linked to this curve. If you wanna hold this column, don't change anything in this combobox."));
> +	cbXColumn->setText(path);

i18n("The column %1 is not available anymore. It will be automatically used once it is created again", m_curve->xColumnPath())

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D22200

To: Murmele, asemke
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190707/86f03146/attachment-0001.html>