D22175: Don't update column name automatically

[Alexander Semke]

asemke added inline comments.

INLINE COMMENTS

> AbstractAspect.cpp:224
> +int AbstractAspect::setName(const QString &value, bool autoUnique) {
>  	if (value.isEmpty()) {
> +		return setName(QLatin1String("1"), autoUnique);

no brackets for one-liners.

> AbstractAspect.h:266
>  public slots:
> -	void setName(const QString&);
> +	int setName(const QString&, bool autoUnique = true);
>  	void setComment(const QString&);

bool as the return type.

> AspectTreeModel.h:97
>  	void hiddenAspectSelected(const AbstractAspect*);
> +	void statusBarMessage(const QString&);
>  };

we have a similar signal already in AbstractAspect::statusInfo(). Let's call it here similarly.

> BaseDock.cpp:3
> +	File                 : BaseDock.cpp
> +    Project              : LabPlot
> +	Description          : Base Dock widget

check the indentation here.

> BaseDock.h:6
> +    --------------------------------------------------------------------
> +    Copyright         : (C) 2010-2015 Martin Marmsoler (martin.marmsoler at gmail.com)
> +

2019 only.

> BaseDock.h:45
> +    bool m_initializing{false};
> +    QLineEdit* leName{nullptr};
> +    QLineEdit* leComment{nullptr};

m_leName

> BaseDock.h:46
> +    QLineEdit* leName{nullptr};
> +    QLineEdit* leComment{nullptr};
> +    AbstractAspect* m_aspect{nullptr};

m_leComment

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D22175

To: Murmele, asemke
Cc: yurchor, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190706/c58922a7/attachment-0001.html>