D22224: Motion control for domes added

Jasem Mutlaq noreply at phabricator.kde.org
Tue Jul 2 21:37:25 BST 2019


mutlaqja requested changes to this revision.
mutlaqja added a comment.
This revision now requires changes to proceed.


  Great work, the observatory module is shaping up nicely!

INLINE COMMENTS

> dome.h:70
> +     */
> +    Q_SCRIPTABLE bool canRelativeMove();
> +    /**

Better use Q_PROPERTY as well like canAbsoluteMove and then expose over DBus in the org.kde.kstars.Ekos.Dome.xml file

> observatory.cpp:425
> +{
> +    domeAzimuthPosition->setText(QString().sprintf("%0.2f°", position));
> +}

Maybe QString::number(position, 'f', 2) ?

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D22224

To: wreissenberger, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190702/f68abcf2/attachment-0001.html>


More information about the kde-edu mailing list