D21841: Multiple datasets for money and smallnumbers activity

[Akshay Kumar]

AkshayCHD marked 2 inline comments as done.
AkshayCHD added inline comments.

INLINE COMMENTS

> jjazeix wrote in Gletters.qml:118
> parent.width * 0.3 seems to small, can you make it at least half of the screen?

@jjazeix I tried using 0.5, but it looks to far stretched https://snag.gy/zfLn6A.jpg (using 0.5)  https://snag.gy/Bkx1MZ.jpg (using 0.3) what do you say

> jjazeix wrote in DialogChooseLevel.qml:207
> just for my information, what do these changes fix?

These changes fix the Binding loop error qrc:/gcompris/src/core/DialogChooseLevel.qml:211:17: QML Button: Binding loop detected for property "implicitHeight"  . Since initially the height of datasetOptionsRow was depended on height of datasetVisibleButton explicitly and height of datasetVisibleButton was depended on height of datasetOptionsRow implicitly which resulted in a binding loop.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D21841

To: AkshayCHD, #gcompris_improvements
Cc: echarruau, jjazeix, kde-edu, #gcompris_improvements, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, andreask, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190701/83da6c26/attachment-0001.html>