D18585: Changes in the menus

Tomaz Canabrava noreply at phabricator.kde.org
Mon Jan 28 16:24:19 GMT 2019


tcanabrava requested changes to this revision.
tcanabrava added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kalgebra.cpp:160-161
> +
> +    QPushButton* enter = new QPushButton("&Enter", this);
> +    QPushButton* clear = new QPushButton("&Clear", this);
> +

please use the translation functions here. it's' the i18n call.

> kalgebra.cpp:516
> +        break;
> +
> +        case 1:

remove this empty space

> kalgebra.cpp:520
> +        break;
> +
> +        case 2:

here too

REPOSITORY
  R325 KAlgebra

REVISION DETAIL
  https://phabricator.kde.org/D18585

To: karinapassos, #kde_edu, tcanabrava, apol
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190128/5519fe65/attachment-0001.html>


More information about the kde-edu mailing list