D17945: Tutorial screen added for odd even activity

[Johnny Jazeix]

jjazeix added a comment.


  I have the following error when starting planegame or alphabet-sequence activities :
  qrc:/gcompris/src/core/Tutorial.qml:136: TypeError: Cannot read property 'length' of undefined
  
  The score shouldn't be visible during the tutorial.
  
  Once the good answer has been clicked, I think we should have a better way to say it's good to the child, not a text below (which can override with the bar).

INLINE COMMENTS

> activities.txt:125
>  photo_hunter
> +piano_composition
>  planegame

this change should not appear

> NumbersOddEven.qml:67
> +                {
> +                    "instruction":  qsTr("Exercise \n To test your understanding."),
> +                    "instructionQml": "qrc:/gcompris/src/activities/numbers-odd-even/resource/Tutorial5.qml"

missing :

> Tutorial1.qml:27
> +Rectangle {
> +    id:tutorialRectangle
> +    anchors.fill: parent

missing space

> Tutorial1.qml:31
> +
> +   GCText {
> +        id: even

missing space in indentation

> Tutorial1.qml:31
> +
> +   GCText {
> +        id: even

GCText {
       id: even
       text: qsTr("For example: 12, 38, 52, 68, 102, 118, 168, 188, 502, 532, 700, 798, 842, 892, 1000. All of these numbers are even numbers as they leave remainder 0 when divisible by 2.")
       fontSizeMode: Text.Fit
       anchors.centerIn: parent
       color: "black"
       width: 0.9 * parent.width
       height: 0.9 * parent.height
       wrapMode: Text.WordWrap
       z: 2
   }

seems better (bigger text at least)?

> Tutorial1.qml:33
> +        id: even
> +        text: qsTr("For example: 12, 38, 52, 68, 102, 118, 168, 188, 502, 532, 700, 798, 842, 892 , 1000.All of these numbers are even numbers as they leave remainder 0 when divisible by 2.")
> +        fontSizeMode: Text.Fit

qsTr("For example: 12, 38, 52, 68, 102, 118, 168, 188, 502, 532, 700, 798, 842, 892 ,1000. All of these numbers are even numbers as they leave remainder 0 when divisible by 2.")

> Tutorial2.qml:33
> +        id: odd
> +        text: qsTr("For example: 15, 19, 51, 65, 103, 119, 169, 185, 505, 533, 701, 799, 845, 897, 1001.All of these numbers are odd numbers as they do not leave remainder 0 when divisible by 2.")
> +        fontSizeMode: Text.Fit

qsTr("For example: 15, 19, 51, 65, 103, 119, 169, 185, 505, 533, 701, 799, 845, 897, 1001. All of these numbers are odd numbers as they do not leave remainder 0 when divisible by 2.")

> TutorialBase.qml:44
> +        }
> +        text: qsTr("Choose the even number")
> +        color: "black"

It would be better to also have on one of the question, the choice to choose the odd number.
Also, having them being on random order (not always the even first, the odd second).

> TutorialBase.qml:53
> +
> +    Rectangle {
> +        id: evenNumberRectangle

it would be better to use a Row to present both numbers and have them take the whole space of the remaining space.
Actually, there are too small.

> TutorialBase.qml:62
> +        color: "transparent"
> +        border.color: "transparent"
> +        width: parent.width / 12

it would be better to have a color surrounding the rectangle so the user knows the click boundaries.
Using a Repeater for both element would avoid duplicating the Rectangle item.

> TutorialBase.qml:107
> +        GCText {
> +        id: oddNumber
> +        anchors {

indentation

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17945

To: dekumar, #gcompris_improvements, jjazeix
Cc: echarruau, amankumargupta, jjazeix, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190127/56947653/attachment-0001.html>