D18476: Fixing

Martin Marmsoler noreply at phabricator.kde.org
Fri Jan 25 06:57:05 GMT 2019

Murmele marked 5 inline comments as done.
Murmele added inline comments.


> asemke wrote in Axis.cpp:1569
> cosinus and sinus only used in the definition of diffx and diffy and can be used there directly.

otherwise sinus and cosinus will be calculated every loop cycle

> asemke wrote in Axis.cpp:1572
> why do you need to check orientation here?

before there was only 
labelsFormat == Axis::FormatDecimal || labelsFormat == Axis::FormatScientificE

but the labelsformat for datetime is different and it cannot be checked, if the labelsFormat == Axis::FormatDecimal ...

> asemke wrote in Axis.cpp:1600
> if I set Rotation=90° and Offset=0pt, I'd expect the label to be positioned right next to the tick and aligned at the center of the rotated label. This is not the case with this logic.

Thats correct :) I have to check.


To: Murmele, asemke
Cc: sgerlach, yurchor, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190125/721d6c28/attachment.html>

More information about the kde-edu mailing list