D18319: Improve LiveDataDock and import widget

Christoph Roick noreply at phabricator.kde.org
Sun Jan 20 15:15:14 GMT 2019


croick added a comment.


  So would you agree, that `qobject_cast` is not required, since the class name is checked anyway?
  The result of the cast isn't checked anywhere, so one could just use `static_cast` (and simply take the first element in the list).

INLINE COMMENTS

> sgerlach wrote in LiveDataDock.cpp:386
> m_mqttClient is only defined if HAVE_MQTT

Thanks, of course.

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D18319

To: croick, #labplot
Cc: sgerlach, asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190120/3f74e0b5/attachment.html>


More information about the kde-edu mailing list